This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix(uniswap-v2): Make cache key generic in helper #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwele
force-pushed
the
fix-uniswap-helper
branch
from
9ee02c7 to
4e0a68f
Compare
immasandwich
approved these changes
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some apps are using the
UniswapV2TheGraphPoolTokenAddressStrategyhelper to perform external query to The Graph. The result is cached for 5 minutes. The problem is the cache has only theNetworkas dynamic parameter, meaning multiple Apps using that helper might have collisions.I am changing the cache key building strategy to prevent that. Now the network, appId and groupId will be used as part of the cache key.
Checklist
How to test?
http://localhost:5001/apps/uniswap-v2/tokens?network=ethereum&groupIds%5B%5D=pool&api_key=562eee97-e90e-42ac-8e7b-363cdff5cdaa