Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: add integration with SINGLE lending vaults #727

Merged
merged 3 commits into from
Jun 23, 2022
Merged

feat: add integration with SINGLE lending vaults #727

merged 3 commits into from
Jun 23, 2022

Conversation

singlefinance
Copy link
Contributor

Description

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

User addresses:
0x5f8e09f5296a6c0e8c34f8e16eda96ecbaf98548
0xbf80bb90e82ae6a8669f75abcaed22f97fe72125
0xef46f5b9d55cc844d0e15322ee513abb3de8a8c8

@singlefinance singlefinance changed the title add integration with SINGLE lending vaults feat: add integration with SINGLE lending vaults Jun 23, 2022
immasandwich
immasandwich reviewed Jun 23, 2022
View reviewed changes
src/apps/single/cronos/single.lending.token-fetcher.ts Outdated
},
resolvePricePerShare: ({ reserve, supply }) => reserve / supply,
});
return [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line 🙏

immasandwich
immasandwich approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@immasandwich immasandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line to be removed, and preferably, rename vault.json to single-vault.json, and regenerate your contract factory.

@singlefinance
Copy link
Contributor Author

singlefinance commented Jun 23, 2022 •
edited
Loading

thank you @immasandwich for the review, we have pushed a fix accordingly :)

@singlefinance singlefinance mentioned this pull request Jun 23, 2022
Merged
3 tasks
@immasandwich immasandwich merged commit b03b54e into Zapper-fi:main Jun 23, 2022
@zapper-bot zapper-bot mentioned this pull request Jun 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@immasandwich immasandwich immasandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singlefinance @immasandwich