This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat: implement velodrome #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immasandwich
reviewed
Jul 6, 2022
| network, | ||
| resolveContract: ({ address, network }) => this.contractFactory.velodromeVe({ address, network }), | ||
| resolveStakedTokenBalance: async ({ contract, address, multicall }) => { | ||
| const veCount = Number(await multicall.wrap(contract).tokenOfOwnerByIndex(address, 0)); |
There was a problem hiding this comment.
This should be balanceOf(address) not tokenOfOwnerByIndex(address, 0) to get the number of ve NFTs held by the address.
|
@tonzgao one last error, I think you put |
|
@tonzgao VELO token coming soon too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://features.zapper.fi/protocol-requests/p/velodrome-on-optimism
note: not affiliated with project
also VELO doesnt seem to be a base token: https://optimistic.etherscan.io/token/0x3c8b650257cfb5f272f799f5e2b4e65093a11a05
Checklist
How to test?
http://localhost:5001/apps/velodrome/tokens?network=optimism&groupIds%5B%5D=pool
http://localhost:5001/apps/velodrome/positions?network=optimism&groupIds%5B%5D=farm
http://localhost:5001/apps/velodrome/balances?network=optimism&addresses%5B%5D=0x4E190B3D31d96e0cD11a1520185a77b57A0182f2