This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat(apps): Add labelDetailed display props for nested display name #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
label
display property is great when there is surrounding context. i.e: We can display Aave V2 USDC deposits asUSDC
within a group labelledSupply
under theAave V2
app in the frontend.aRAI
, it ends up displaying asRAI
.aUSDC
andUSDC
appears asUSDC / USDC
label
: Use this label within a framed context, like in the Aave V2 explore page under theSupply
token grouplabelDetailed
: Use this label within detailed contexts like a token breakdown, or within a higher level labelsymbol
in any display context because of the fact thatsymbol
is extremely user unfriendly.Checklist
How to test?