Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(apps): Add labelDetailed display props for nested display name #920

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

immasandwich
Copy link
Contributor

@immasandwich immasandwich commented Jul 20, 2022

Description

  • The label display property is great when there is surrounding context. i.e: We can display Aave V2 USDC deposits as USDC within a group labelled Supply under the Aave V2 app in the frontend.
  • However, when this label is used within another label, we lose context.
    • Example 1: if we use this label in Rari Fuse for collateral aRAI, it ends up displaying as RAI.
    • Example 2: if we use this label in Balancer V2, the pool of aUSDC and USDC appears as USDC / USDC
  • As such, we need to support two separate labels:
    • label: Use this label within a framed context, like in the Aave V2 explore page under the Supply token group
    • labelDetailed: Use this label within detailed contexts like a token breakdown, or within a higher level label
  • Note: We generally want to avoid explicitly using symbol in any display context because of the fact that symbol is extremely user unfriendly.

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

@immasandwich immasandwich merged commit be2629e into main Jul 20, 2022
@immasandwich immasandwich deleted the add-label-detailed branch July 20, 2022 18:27
volt62 pushed a commit to volt62/zapper-studio that referenced this pull request Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant