-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing the new zebra-scanner
binary
#8585
Comments
@oxarbitrage what else do we need to do in order to close off this issue? |
I think what we wanted to do here is actually done. What i will like to do at some point (and we can mark it as optional for now) is to add a test that checks the scanner behavior when we are synced up to the tip. This can be complicated to do so we will probably not do now. Do you want me to close this issue and open another one just for that ? |
yes please! |
Closing and opening #8697 for the optional remaining test. |
We have some good test coverage for our blockchain scanner and most of them will keep working after we introduce a new binary (#8581) however tests that relies on the scanner being started by zebrad will fail. We need to replace these by specific tests in the new binary scope. We may also want to add more tests and add the build of this binary into the CI.
More details to be added.
Note: #8631 should be reverted if/when the
scan-start-where-left-test
test is restored.The text was updated successfully, but these errors were encountered: