Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the new zebra-scanner binary #8585

Closed
oxarbitrage opened this issue Jun 4, 2024 · 4 comments · Fixed by #8659
Closed

Testing the new zebra-scanner binary #8585

oxarbitrage opened this issue Jun 4, 2024 · 4 comments · Fixed by #8659
Assignees
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests P-Medium ⚡

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Jun 4, 2024

We have some good test coverage for our blockchain scanner and most of them will keep working after we introduce a new binary (#8581) however tests that relies on the scanner being started by zebrad will fail. We need to replace these by specific tests in the new binary scope. We may also want to add more tests and add the build of this binary into the CI.

More details to be added.

Note: #8631 should be reverted if/when the scan-start-where-left-test test is restored.

@mpguerra
Copy link
Contributor

@oxarbitrage what else do we need to do in order to close off this issue?

@oxarbitrage
Copy link
Contributor Author

I think what we wanted to do here is actually done.

What i will like to do at some point (and we can mark it as optional for now) is to add a test that checks the scanner behavior when we are synced up to the tip. This can be complicated to do so we will probably not do now. Do you want me to close this issue and open another one just for that ?

@mpguerra
Copy link
Contributor

yes please!

@mpguerra mpguerra moved this from Sprint Backlog to In progress in Zebra Jul 17, 2024
@mpguerra mpguerra linked a pull request Jul 17, 2024 that will close this issue
7 tasks
@oxarbitrage
Copy link
Contributor Author

Closing and opening #8697 for the optional remaining test.

@github-project-automation github-project-automation bot moved this from In progress to Done in Zebra Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests P-Medium ⚡
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants