Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: Launch replay. #1343

Closed
GoogleFrog opened this issue Nov 25, 2016 · 9 comments
Closed

Wrapper: Launch replay. #1343

GoogleFrog opened this issue Nov 25, 2016 · 9 comments

Comments

@GoogleFrog
Copy link
Contributor

The wrapper should have a command to launch a given replay file. Chobby will make sure that the appropriate game and map are downloaded. It should also send a request to the wrapper to download the engine prior to sending the "launch replay" command, however, the wrapper should probably be able to download the required engine itself.

The wrapper needs to be able to receive a springsettings to use. If it uses the springsettings present in the base folder then it will launch spring with the wrong settings, namely fullscreen mode. I am unsure how to solve this. Perhaps there is a cmdline way to override settings.

@mojjj
Copy link
Contributor

mojjj commented Jan 17, 2017

Spring-Chobby/Chobby#385

@Licho1
Copy link
Member

Licho1 commented Jan 17, 2017

The settings change requirements is holding this back. No idea how to arrange that. Any ideas?

@GoogleFrog
Copy link
Contributor Author

I can change springsettings using Spring.SetConfigInt and then tell the wrapper to start the game. However this will cause chobby to go fullscreen and it may block the game.

@GoogleFrog
Copy link
Contributor Author

I can write a settings file to a subdirectory.

@GoogleFrog
Copy link
Contributor Author

I could send you a table of the settings to apply and wrapper could write that to settings file. Implement this without doing the settings and see how we go.

@Licho1
Copy link
Member

Licho1 commented Feb 7, 2017

Table as function param sounds good will probably do that.
But how do we restore it back?
Its probably task for engine to allow som temporary override.

@Licho1
Copy link
Member

Licho1 commented Feb 27, 2017

fixed by c22f4db

@Licho1 Licho1 closed this as completed Feb 27, 2017
@mojjj
Copy link
Contributor

mojjj commented Mar 30, 2017

so can chobby now download replays with older engines and start them?

@Licho1
Copy link
Member

Licho1 commented Mar 30, 2017

No, not really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants