Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Rotation::reset() does not change the absolute angle of the rotation sensor #2

Closed
NoahK216 opened this issue Feb 19, 2025 · 1 comment
Labels
ready this issue is ready to be worked on

Comments

@NoahK216
Copy link

NoahK216 commented Feb 19, 2025

Referring to purduesigbots/pros#688

Describe the bug
There is no way to set the absolute angle measured by the rotation sensor to 0

To Reproduce
Steps to reproduce the behavior:

  1. Instantiate a rotation sensor
  2. try to zero the sensor with Rotation::reset()
  3. Observe that the measured absolute angle does not change

Expected behavior
For Rotation::reset() to zero the absolute position of the encoder

Screenshots
N/A

Desktop (please complete the following information):
N/A

Kernel Version: 4.1.0

Additional context
Also, the docs don't distinguish between Rotation::get_position and Rotation::get_angle

Image

@NoahK216 NoahK216 added the bug label Feb 19, 2025
@SizzinSeal SizzinSeal changed the title 🐛[BUG] Rotation::reset() does not change the absolute angle of the rotation sensor 🐛Rotation::reset() does not change the absolute angle of the rotation sensor Feb 20, 2025
@SizzinSeal SizzinSeal added this to the No More Upstream Bugs milestone Feb 23, 2025
@SizzinSeal SizzinSeal added ready this issue is ready to be worked on and removed bug labels Feb 24, 2025
@SizzinSeal SizzinSeal changed the title 🐛Rotation::reset() does not change the absolute angle of the rotation sensor 🐛:memo: Rotation::reset() does not change the absolute angle of the rotation sensor Feb 24, 2025
@SizzinSeal SizzinSeal changed the title 🐛:memo: Rotation::reset() does not change the absolute angle of the rotation sensor 🐛Rotation::reset() does not change the absolute angle of the rotation sensor Feb 24, 2025
@SizzinSeal SizzinSeal removed this from the No More Upstream Bugs milestone Feb 24, 2025
@ion098
Copy link
Contributor

ion098 commented Mar 4, 2025

Since the device API has been annihilated, this is no longer an issue.

@ion098 ion098 closed this as completed Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready this issue is ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants