Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Review the use of READ_ONLY_FLAG in cases we should use it #183

Closed
emmanuelm41 opened this issue Jan 28, 2023 · 3 comments · Fixed by #199 or #233
Closed

Review the use of READ_ONLY_FLAG in cases we should use it #183

emmanuelm41 opened this issue Jan 28, 2023 · 3 comments · Fixed by #199 or #233
Assignees
@emmanuelm41
Labels
enhancement New feature or request
Milestone
Release - CW 8

Comments

@emmanuelm41
Copy link
Member

emmanuelm41 commented Jan 28, 2023 •
edited by zboto bot
Loading

Whenever we tried to use READ_ONLY_FLAG in methods that should be read only, we broke CI tests. Let's check what is happening this flag. We should use it in cases the state is not going to be changed.

🔗 zboto Link
@emmanuelm41 emmanuelm41 added enhancement New feature or request question Further information is requested labels Jan 30, 2023
@emmanuelm41
Copy link
Member Author

emmanuelm41 commented Jan 30, 2023 •
edited by zboto bot
Loading

We are currently asking filecoin about this flag.

@emmanuelm41 emmanuelm41 mentioned this issue Jan 31, 2023
Merged
@emmanuelm41
Copy link
Member Author

emmanuelm41 commented Jan 31, 2023 •
edited by zboto bot
Loading

Reopening issue because we still need to make some methods read only. Both ones cannot be used as read only because an issue on the builtin actors code. Need to update the submodule to a newer version after the issue is fixed.

Miner --> getBeneficiary
VerifReg --> getClaims

@emmanuelm41 emmanuelm41 reopened this Jan 31, 2023
@emmanuelm41 emmanuelm41 added BLOCKED and removed question Further information is requested labels Feb 1, 2023
@emmanuelm41 emmanuelm41 removed their assignment Feb 2, 2023
@emmanuelm41
Copy link
Member Author

emmanuelm41 commented Feb 3, 2023 •
edited by zboto bot
Loading

Update being applied here #209

@emmanuelm41 emmanuelm41 mentioned this issue Feb 17, 2023
Merged
@ainhoa-a ainhoa-a added this to the Release - CW 8 milestone Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@emmanuelm41 emmanuelm41

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release - CW 8
2 participants
@emmanuelm41 @ainhoa-a