Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #710 Added libavformat version check around free context functions #711

Conversation

SteveGilvarry
Copy link
Member

Just put in standard version check code for new ffmpeg API functions.

@SteveGilvarry SteveGilvarry changed the title Fixes #720 Added libavformat version check around free context functions Fixes #710 Added libavformat version check around free context functions Feb 18, 2015
@knight-of-ni
Copy link
Member

nice catch @SteveGilvarry
Fix for #710 <- to get github to link the two issues.

Looks good, but one question. Did you verify whether or not (our nemesis) libav has this new function call?

@knight-of-ni
Copy link
Member

Can't seem to find a reference to this call in libav, but this might be due to user error.

@SteveGilvarry
Copy link
Member Author

Is from 2011, which is fork year, but I think it was pre-fork so same change is in both, hence no need for a micro version >100 check here.

https://github.com/libav/libav/blob/master/doc/APIchanges#L1055

knight-of-ni pushed a commit that referenced this pull request Feb 18, 2015
…version_check

Fixes #710 Added libavformat version check around free context functions
@knight-of-ni knight-of-ni merged commit 6c65c89 into ZoneMinder:master Feb 18, 2015
@SteveGilvarry SteveGilvarry deleted the 720_avformat_free_context_version_check branch July 28, 2015 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants