Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New language: German #466

Closed
pliablepixels opened this issue Feb 25, 2017 · 6 comments
Closed

New language: German #466

pliablepixels opened this issue Feb 25, 2017 · 6 comments

Comments

@pliablepixels
Copy link
Member

Credit @florie1706

#465

@pliablepixels
Copy link
Member Author

@florie1706 - its easiest for you to test on a desktop version - which desktop version do you use ? I can send you a test version

@florie1706
Copy link
Contributor

@pliablepixels - I always use your zmNinja-win64bit on a Windows 10 machine

@pliablepixels
Copy link
Member Author

@florie1706
Copy link
Contributor

Any chance to have a test build with my current lang file? Wasn't able to test the new language file yet. Otherwise I will wait for your next official release :)

@pliablepixels
Copy link
Member Author

pliablepixels commented Mar 2, 2017

sure - BTW, forgot to respond to one of your questions - I'd prefer you don't put in zmNinja inside your language files. I append the app name as the last word in code (this is because the app name is configurable). You've encoded the app name in two strings

https://github.com/pliablepixels/zmNinja/blob/master/www/lang/locale-de.json#L345 (in this instance I add the app name at the end of the string. I don't have a way to have the app name inserted mid-string as you requested)

https://github.com/pliablepixels/zmNinja/blob/master/www/lang/locale-de.json#L391

Can you please remove those ?

@pliablepixels
Copy link
Member Author

I'll be making a new release soon - can you please update the latest key ? I added an extra key for HTTP timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants