Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit/fill screen option issue #514

Closed
psyhomb opened this issue Apr 21, 2017 · 3 comments
Closed

fit/fill screen option issue #514

psyhomb opened this issue Apr 21, 2017 · 3 comments

Comments

@psyhomb
Copy link

psyhomb commented Apr 21, 2017

First of all, great app and keep up the good work!

I'm currently using zmNinja on two Android phones LG Nexus 5X and LG L Bello and
on first one I have no issues at all and app is working really great, but on later device I'm experiencing an issue with fit/fill screen option, it simply doesn't work, and stream apparently is always in full screen mode but it's unproportionally scaled and it cannot be changed, on the other hand when I'm watching events on the same device, video is always in fit screen mode and everything looks ok.

I don't claim it has anything to do with the app itself, moreover it looks to me like it is device related anyhow I am reaching you for help and suggestion.

Platform & OS Version
Android OS, v4.4.2 (KitKat)

The version of the app you are reporting:
zmNinja v1.2.41

Device details:
http://www.lg.com/in/mobile-phones/lg-L-Bello-D335

What is the nature of your issue
fit/fill screen option doesn't work in live view mode

Thanks

@pliablepixels
Copy link
Member

pliablepixels commented Apr 22, 2017

Hi, glad you like the app.

Its interesting that it renders perfectly for events but not for live view. I am basically using CSS to scale the image (object-fit: cover/contain)

The code is the same to scale: live view scaling/event view scaling - see the ng-class part.

I wonder if this has anything to do with the dimension of the phone relative to the video size?
Can you post a screen shot?

@pliablepixels
Copy link
Member

Also, I just noticed that phone in question is 4.4.2 that means it uses crosswalk and not the native browser. That may also be a reason. I'll test on a similar phone and see (if I can find an emulator image)

@psyhomb
Copy link
Author

psyhomb commented Apr 23, 2017

Hey, thanks for the quick answer.

Last night I installed Android 5.0.2 (Lollipop) on my LG L Bello and now application is working perfectly.

Thanks once again.

@psyhomb psyhomb closed this as completed Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants