Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conventional commits #2279

Open
keikoro opened this issue Dec 4, 2024 · 3 comments
Open

Support conventional commits #2279

keikoro opened this issue Dec 4, 2024 · 3 comments
Labels
feature-request Request for a new feature or additional functionality. project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.

Comments

@keikoro
Copy link
Collaborator

keikoro commented Dec 4, 2024

I'd like to propose we introduce conventional commits to increase the specificity of commits/for better differentiation of commits/overall quality of commit messages.

Having had a look at recently submitted PRs, I feel like requiring a commit message type would reduce the number of PRs which try to do too much at once because it a) forces people to consciously think about what a commit is trying to achieve and b) makes it immediately obvious when there's a potential lack of separation of concerns (e.g. lots of different types mixed together).

@keikoro keikoro added feature-request Request for a new feature or additional functionality. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". labels Dec 4, 2024
@keikoro
Copy link
Collaborator Author

keikoro commented Dec 4, 2024

Gitlint could be used in a GitHub workflow to enforce CC types, see their Contrib Rules docs.

@keikoro
Copy link
Collaborator Author

keikoro commented Dec 4, 2024

Conventional commits can also help with better structured release notes, e.g. when used with actions like release-please.

@OsaAjani
Copy link
Collaborator

OsaAjani commented Dec 4, 2024

I do like the general idea of more standardized commit but I fear this would be yet another obstacle on the path for debutant people just trying to help.
It's always a hard choice between more rules for better uniformity and more freedom for less hassle ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature or additional functionality. project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Development

No branches or pull requests

2 participants