Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFS directory listing #196

Open
SamTebbs33 opened this issue Jul 21, 2020 · 2 comments · May be fixed by #313
Open

VFS directory listing #196

SamTebbs33 opened this issue Jul 21, 2020 · 2 comments · May be fixed by #313
Labels
arch: none Affects common code across architectures enhancement New feature or request good first issue Good for newcomers

Comments

@SamTebbs33
Copy link
Collaborator

The virtual filesystem should support listing the children of directories. Slices may be useful for this.

@SamTebbs33 SamTebbs33 added arch: none Affects common code across architectures enhancement New feature or request labels Jul 21, 2020
@SamTebbs33 SamTebbs33 added this to the v0.3 milestone Jul 21, 2020
@SamTebbs33 SamTebbs33 added the good first issue Good for newcomers label Aug 16, 2020
@iamgweej
Copy link
Contributor

Should this be a part of the FileSystem struct or the DirNode struct? What would make more sense?
Also, I don't know if slices are the best for this. I think some filesystems use linked-lists to specify directory entries, so maybe some sort of an iterator would be more convenient for this.

@SamTebbs33
Copy link
Collaborator Author

SamTebbs33 commented Aug 29, 2020

I think it should be part of DirNode since it makes sense to have to open the dir in order to list its children. It's also nice to encapsulate operations on nodes within the node struct itself. With regards to slices vs lists, whatever makes for a cleaner implementation and uses least memory is what we should go for, IMO. Slices can be iterated upon and lists can be converted to a slice with toOwnedSlice (last time I checked!).

@SamTebbs33 SamTebbs33 removed this from the v0.3 milestone Nov 23, 2020
@SamTebbs33 SamTebbs33 linked a pull request Oct 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch: none Affects common code across architectures enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants