Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YamlDotNet should use attribute System.Runtime.Serialization.Datamember #461

Open
ramon-garcia opened this issue Dec 21, 2019 · 1 comment
Open

YamlDotNet should use attribute System.Runtime.Serialization.Datamember #461

ramon-garcia opened this issue Dec 21, 2019 · 1 comment
Labels
enhancement good-first-issue This should be easy to pick up if you want to get started.

Comments

@ramon-garcia
Copy link

Although there is already an attribute YamlMember, DataMember does not depend on Yaml, and allows one to have consistent serialized field names in YamlDotNet and System.Text.Json

Best regards.
@aaubry aaubry added enhancement good-first-issue This should be easy to pick up if you want to get started. labels Mar 13, 2020
@aaubry
Copy link
Owner

aaubry commented Mar 13, 2020

Adding this support would consist of creating an implementation of ITypeInspector that inspects the DataMember attribute to enrich the metadata. The implementation should be similar to YamlAttributesTypeInspector

@fglaeser fglaeser mentioned this issue Mar 21, 2020
Closed
@aaubry aaubry mentioned this issue Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good-first-issue This should be easy to pick up if you want to get started.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaubry @ramon-garcia