Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow gho steward param change in both directions #401

Closed
brotherlymite opened this issue May 10, 2024 · 1 comment
Closed

fix: allow gho steward param change in both directions #401

brotherlymite opened this issue May 10, 2024 · 1 comment

Comments

@brotherlymite
Copy link

For more flexibility and feedback from riskCouncil, I think the GhoStewardV2 should allow changing the facilitatorBucketCapacity, ghoBorrowCap, gsmExposureCap, gsmBuySellFees in both the directions (increase / decrease).

Should be quite straightforward using the _isDifferenceLowerThanMax method instead of _isIncreaseLowerThanMax.

Also this comment, should be patched from PoolAdmin to RiskAdmin imo and the tests should be fixed as the RiskAdmin role should be sufficient.

@miguelmtzinf
Copy link
Contributor

Thanks @brotherlymite for raising this issue.

Steward design and capabilities are decided by governance discussion. #402 updates the contract based on the last discussion of the gov thread.
The design and capabilities of the steward are determined through governance discussions. PR#402 modifies the contract in line with the latest discussions from the governance thread.

#402 fixes the nastpec docs of the contract, so closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants