Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidation penalty tooltip is misleading for V3 markets #1279

Open
drewcook opened this issue Oct 27, 2022 · 0 comments
Open

Liquidation penalty tooltip is misleading for V3 markets #1279

drewcook opened this issue Oct 27, 2022 · 0 comments
Labels
bug Something isn't working new issue This issue has not been triaged by the core team yet

Comments

@drewcook
Copy link
Contributor

Describe the bug

In V2 markets, liquidation can occur on up to 50% of the total borrowed and repaid with the given collateralized asset. However, in V3 markets, there is no restriction to how much of the total borrowed is repaid with the collateralized asset. Up to 100% can be repaid on a liquidationCall call on the contract. Thus, the tooltip is misleading for V3 markets.

Also, it can be argued that even the 50% restriction makes little sense, as a user can get liquidated for 50% of their borrowed positions, but then the same bot/address that calls liquidationCall to liquidate the user's supplied collateral can immediately do a secondary call to repay the other 50%. So it may be useful to just update the text altogether and remove the details about percentages.

Otherwise, there should be distinguishable text content between V2 and V3 markets for this tooltip, with respect to 50% and 100%.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any reserve page in V2
  2. Hover over the "Liquidation penalty" tooltip
  3. View text
  4. Repeat steps 1-3 on a V3 market for any given reserve
  5. View the same text which is innaccurate

Expected behavior

The tooltip text should be updated to include content that to be either one singular, more generic and agnostic statement about liquidations, or relevant to the given market, i.e. V2/V3.

Screenshots

Notice the V3 market and the text stating up to 50%.

image

@drewcook drewcook added bug Something isn't working new issue This issue has not been triaged by the core team yet labels Oct 27, 2022
@drewcook drewcook reopened this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new issue This issue has not been triaged by the core team yet
Projects
None yet
Development

No branches or pull requests

1 participant