Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atoken symbols when adding to wallet are wrong #942

Open
sakulstra opened this issue Jul 16, 2022 · 3 comments
Open

Atoken symbols when adding to wallet are wrong #942

sakulstra opened this issue Jul 16, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@sakulstra
Copy link
Collaborator

sakulstra commented Jul 16, 2022

Describe the bug
Tokens are added as a${TokenName} which strictly speaking is wrong (only on eth mainnet the symbol is a${TokenName} - it's different on every other pool.

To Reproduce
Steps to reproduce the behavior:

  1. Go to app.aave.com
  2. Add a aToken to your wallet

Expected behavior
The token name should be correct, otherwise it's confusing with dexes who show the correct name.

Additional context
Might make sense to just return the aTokenSymbol from the uiPoolDataProvider as it's generally not as simple as adding a prefix to the underlying symbol.
Idk know though how reasonable it is to fetch all the symbols and names every few seconds. Might be more reasonable to actually split this in two requests where the one responsible for symbol and so on would be fetched a lot less frequently (for most tokens it's essentially static).

@sakulstra sakulstra added the bug Something isn't working label Jul 16, 2022
@drewcook drewcook reopened this Jan 12, 2023
@Jdecristi
Copy link
Contributor

Jdecristi commented May 24, 2023

@sakulstra @drewcook @defispartan is this still an issue? I looked and can't find "a${TokenName}" in the codebase and when looking at the AddTokenDropdown component. It pulls from the poolReserve

@sakulstra
Copy link
Collaborator Author

image

I think it's still an issue ( in this case should be aOptDai https://optimistic.etherscan.io/address/0x82E64f49Ed5EC1bC6e43DAD4FC8Af9bb3A2312EE )

@Jdecristi
Copy link
Contributor

Jdecristi commented Jun 16, 2023

@sakulstra after looking into it, I found that UiPoolDataProvider, where the aTokenAddress is provided, doesn't provide the aTokenSymbol. This fix should be fixed in the @aave/contract-helpers module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants