You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Tokens are added as a${TokenName} which strictly speaking is wrong (only on eth mainnet the symbol is a${TokenName} - it's different on every other pool.
To Reproduce
Steps to reproduce the behavior:
Go to app.aave.com
Add a aToken to your wallet
Expected behavior
The token name should be correct, otherwise it's confusing with dexes who show the correct name.
Additional context
Might make sense to just return the aTokenSymbol from the uiPoolDataProvider as it's generally not as simple as adding a prefix to the underlying symbol.
Idk know though how reasonable it is to fetch all the symbols and names every few seconds. Might be more reasonable to actually split this in two requests where the one responsible for symbol and so on would be fetched a lot less frequently (for most tokens it's essentially static).
The text was updated successfully, but these errors were encountered:
@sakulstra@drewcook@defispartan is this still an issue? I looked and can't find "a${TokenName}" in the codebase and when looking at the AddTokenDropdown component. It pulls from the poolReserve
@sakulstra after looking into it, I found that UiPoolDataProvider, where the aTokenAddress is provided, doesn't provide the aTokenSymbol. This fix should be fixed in the @aave/contract-helpers module
Describe the bug
Tokens are added as
a${TokenName}
which strictly speaking is wrong (only on eth mainnet the symbol isa${TokenName}
- it's different on every other pool.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The token name should be correct, otherwise it's confusing with dexes who show the correct name.
Additional context
Might make sense to just return the aTokenSymbol from the uiPoolDataProvider as it's generally not as simple as adding a prefix to the underlying symbol.
Idk know though how reasonable it is to fetch all the symbols and names every few seconds. Might be more reasonable to actually split this in two requests where the one responsible for symbol and so on would be fetched a lot less frequently (for most tokens it's essentially static).
The text was updated successfully, but these errors were encountered: