Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mobile friendly #11

Open
aawgit opened this issue Sep 18, 2022 · 9 comments
Open

Make mobile friendly #11

aawgit opened this issue Sep 18, 2022 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@aawgit
Copy link
Owner

aawgit commented Sep 18, 2022

No description provided.

@abitsalihu
Copy link

@aawgit make this mobile friendly using css?

@aawgit
Copy link
Owner Author

aawgit commented Sep 19, 2022

Hi @abitsalihu There are two aspects.

  • The UI should be improved to fit better on a mobile phone screen. It is not bad as it is but could be improved.
  • Core functionality i.e. pose estimation and classification should be tested and improved.

@aawgit aawgit added the help wanted Extra attention is needed label Sep 30, 2022
@ghost
Copy link

ghost commented Dec 4, 2022

Hey @aawgit,

I'd be happy to take a look at this if that's OK for you!

@aawgit aawgit assigned aawgit and ghost and unassigned aawgit Dec 6, 2022
@aawgit
Copy link
Owner Author

aawgit commented Dec 6, 2022

@dadolhay Sounds good. Assigned it to you.

@ghost ghost mentioned this issue Dec 6, 2022
Closed
@ghost
Copy link

ghost commented Dec 6, 2022

Hey @aawgit,

Thanks!
I posted a PR for this task, please let me know if you encounter any issues!

@aawgit
Copy link
Owner Author

aawgit commented Dec 7, 2022

Thanks @dadolhay, I'll review it. It might take me a few days. Sorry for the delay in advance. BTW have you tested it on a mobile phone?

@ghost
Copy link

ghost commented Dec 7, 2022

@aawgit Yes, it works on android + chrome

@ghost
Copy link

ghost commented Dec 7, 2022

Note: It always requires https on mobile devices

@ghost
Copy link

ghost commented Dec 7, 2022

Resolved merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 11
2 participants
@aawgit @abitsalihu