feat: Adds working_directory Input to Action #14
Conversation
This allows the user to set the directory in which poetry commands are run in. This enabled compatibility for projects with no pyproject.toml in root of the repository.
MrFlynn
changed the title
|
Hey @MrFlynn! Thank you so much for this pull request. I'm really glad to have this! Could we consider implementing this slightly differently? Instead of checking for the variable's existence and it being non-empty, I'd rather have the variable get set with a default value of And then also, please add usage of this variable to the I just value having the explicit config. If you could update these, I can merge this shortly after. |
Removed check for INPUT_WORKING_DIRECTORY having a non-null value before changing directory. Default behavior will be to cd into current directory.
Added variable to ci.yml for completeness purposes.
|
I agree with everything you said. I had originally given I also updated the example in the README and added the input to |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR contains a change that allows the user of the action to specify a working directory where their project is located. Currently, this action assumes that the
pyproject.tomlis located in the root of the repository, which isn't always the case.Other minor changes include changing the entrypoint shell from
shtobashand some shell style fixes (as indicated by shellcheck).