Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: default column headers can now have different naming methods #13

Merged
merged 5 commits into from
Oct 21, 2015

Conversation

Samuel29
Copy link
Contributor

I am editing a 130+ columns file whose column definition is in a separate file, with numeric indexes. converting "EC" to 133 was not straight forward :)

@Samuel29
Copy link
Contributor Author

ok thanks for comments, I'll close / reopen.

@Samuel29 Samuel29 closed this Oct 21, 2015
@abe33
Copy link
Owner

abe33 commented Oct 21, 2015

You didn't need to close it, just make the changes and push them (and rebase if you really want to clean the git history)

@Samuel29 Samuel29 reopened this Oct 21, 2015
@Samuel29
Copy link
Contributor Author

can't figure out why TravisCI is throwing my PR. any idea?

@abe33
Copy link
Owner

abe33 commented Oct 21, 2015

It happens sometime, probably a race condition somewhere that I haven't identified yet. Don't mind it much, there was a build that passed so it's 🆗 for me.

Anyway, thanks for taking care of that.

abe33 added a commit that referenced this pull request Oct 21, 2015
Add new default columns naming strategies
@abe33 abe33 merged commit 37c381a into abe33:master Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants