Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stateChange nonnull? #1017

Closed
ricardopereira opened this issue Apr 30, 2020 · 0 comments · Fixed by #1156
Closed

Make stateChange nonnull? #1017

ricardopereira opened this issue Apr 30, 2020 · 0 comments · Fixed by #1156
Assignees
@maratal
Labels
enhancement New feature or improved functionality.

Comments

@ricardopereira
Copy link
Contributor

ricardopereira commented Apr 30, 2020 •
edited by sync-by-unito bot
Loading

Why is the stageChange optional? I don't see a way where the stateChange will be nil. In my opinion, having the stateChange nonnull will improve the experience for the user.

Screenshot 2020-04-23 at 09 31 25

┆Issue is synchronized with this Jira Story by Unito
@ricardopereira ricardopereira added enhancement New feature or improved functionality. realtime labels May 21, 2020
@maratal maratal self-assigned this Jul 15, 2021
@maratal maratal linked a pull request Jul 24, 2021 that will close this issue
1017 state change nonnull #1156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1017 state change nonnull ably/ably-cocoa
2 participants
@ricardopereira @maratal