Unused function warnings in xdelta3.x when Ably added via CocoaPods - Unused Entity Issue

[QuintinWillison]

I installed the 'Ably' pod version 1.2.0 in to a brand new Xcode project. After pod install I opened the workspace and asked the app to launch in a simulator. The build came up with two warnings:

CompileC /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/Objects-normal/x86_64/xdelta3.o /Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods/AblyDeltaCodec/xdelta/xdelta3/xdelta3.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler (in target 'AblyDeltaCodec' from project 'Pods')
    cd /Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods
    export LANG=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c -target x86_64-apple-ios8.0-simulator -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu11 -fmodules -gmodules -fmodules-cache-path=/Users/quintin/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval=86400 -fmodules-prune-after=345600 -fbuild-session-file=/Users/quintin/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror=non-modular-include-in-framework-module -fmodule-name=AblyDeltaCodec -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wdocumentation -Wunreachable-code -Werror=deprecated-objc-isa-usage -Werror=objc-root-class -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -DPOD_CONFIGURATION_DEBUG=1 -DDEBUG=1 -DCOCOAPODS=1 -DHAVE_CONFIG_H=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.2.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -g -Wno-sign-conversion -Winfinite-recursion -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wno-semicolon-before-method-body -Wunguarded-availability -index-store-path /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Index/DataStore -iquote /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/AblyDeltaCodec-generated-files.hmap -I/Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/AblyDeltaCodec-own-target-headers.hmap -I/Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/AblyDeltaCodec-all-non-framework-target-headers.hmap -ivfsoverlay /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/all-product-headers.yaml -iquote /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/AblyDeltaCodec-project-headers.hmap -I/Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Products/Debug-iphonesimulator/AblyDeltaCodec/include -I/Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/DerivedSources-normal/x86_64 -I/Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/DerivedSources/x86_64 -I/Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/DerivedSources -F/Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Products/Debug-iphonesimulator/AblyDeltaCodec -include /Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods/Target\ Support\ Files/AblyDeltaCodec/AblyDeltaCodec-prefix.pch -MMD -MT dependencies -MF /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/Objects-normal/x86_64/xdelta3.d --serialize-diagnostics /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/Objects-normal/x86_64/xdelta3.dia -c /Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods/AblyDeltaCodec/xdelta/xdelta3/xdelta3.c -o /Users/quintin/Library/Developer/Xcode/DerivedData/TestThreadSanitizer-ftwgwofpcnavqadgdxsvanmowjfn/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/AblyDeltaCodec.build/Objects-normal/x86_64/xdelta3.o

/Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods/AblyDeltaCodec/xdelta/xdelta3/xdelta3.c:354:1: warning: unused function 'xd3_rlist_length' [-Wunused-function]
XD3_MAKELIST(xd3_rlist, xd3_rinst, link);
^
In file included from /Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods/AblyDeltaCodec/xdelta/xdelta3/xdelta3.c:351:
/Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods/AblyDeltaCodec/xdelta/xdelta3/xdelta3-list.h:114:73: note: expanded from macro 'XD3_MAKELIST'
static inline usize_t                                                   \
                                                                        ^
<scratch space>:25:1: note: expanded from here
xd3_rlist_length
^
/Users/quintin/code/experiments/cocoa/TestThreadSanitizer/Pods/AblyDeltaCodec/xdelta/xdelta3/xdelta3.c:479:20: warning: unused function 'xd3_emit_uint32_t' [-Wunused-function]
static int         xd3_emit_uint32_t (xd3_stream *stream, xd3_output **output,
                   ^
2 warnings generated.

This is not a nice first impression for developers who have just added Ably to their project.

┆Issue is synchronized with this Jira Story by Unito

[maratal]

Fixed here: ably/delta-codec-cocoa#20 (new version should be released)