Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra callback with setSuspended #1550

Closed
maratal opened this issue Dec 4, 2022 · 1 comment · Fixed by #1551
Closed

Remove extra callback with setSuspended #1550

maratal opened this issue Dec 4, 2022 · 1 comment · Fixed by #1551
Assignees
@maratal

Comments

@maratal
Copy link
Collaborator

maratal commented Dec 4, 2022 •
edited by sync-by-unito bot
Loading

Could you open this one as a separate PR? I think that if it's a bug fix then we should give it a proper review separately.

Originally posted by @lawrence-forooghian in #1520 (comment)

I think it's a bug calling setSuspended here, bc it's being called from attachAfterChecks. Also it leads to the channel emit .suspended twice in a raw, which I guess is not intended.

21b207f
@maratal maratal self-assigned this Dec 4, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 4, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3124

@maratal maratal mentioned this issue Dec 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/1550 extra callback with set suspended ably/ably-cocoa
1 participant
@maratal