Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement connection state freshness check #645

Closed
SimonWoolf opened this issue Nov 10, 2017 · 3 comments
Closed

Implement connection state freshness check #645

SimonWoolf opened this issue Nov 10, 2017 · 3 comments
Labels
enhancement New feature or improved functionality.

Comments

@SimonWoolf
Copy link
Member

SimonWoolf commented Nov 10, 2017 •
edited
Loading

Spec PR: https://github.com/ably/docs/pull/331/files

This is quite high priority; see https://github.com/ably/realtime/issues/1289#issuecomment-341152556 for why, or ask me or Matt in #client-libraries on slack

See https://github.com/ably/ably-js/blob/c55b4518d6f096e4bde90afcd04c5ba35d466f3c/common/lib/transport/connectionmanager.js#L702-L712 for example implementation
@SimonWoolf SimonWoolf added the enhancement New feature or improved functionality. label Nov 10, 2017
@SimonWoolf SimonWoolf mentioned this issue Dec 11, 2017
Merged
@funkyboy
Copy link
Contributor

@SimonWoolf This looks like it's been "fixed" here: #660
Can I close?

@SimonWoolf
Copy link
Member Author

This looks like it's been "fixed" here: #660

No, that pr didn't implement RTN15g, which is what this issue is about. See comment #660 (comment) for more context.

@funkyboy
Copy link
Contributor

Closed by #719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funkyboy @SimonWoolf