Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when using authUrl with authMethod=POST, authParams are sent JSON-encoded, not form-encoded #690

Closed
SimonWoolf opened this issue Feb 12, 2018 · 1 comment
Closed

when using authUrl with authMethod=POST, authParams are sent JSON-encoded, not form-encoded #690

SimonWoolf opened this issue Feb 12, 2018 · 1 comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@SimonWoolf
Copy link
Member

SimonWoolf commented Feb 12, 2018 •
edited by sync-by-unito bot
Loading

Customer reports that ably-ios doesn't conform to https://docs.ably.io/client-lib-development-guide/features/#RSA8c1b -- i.e. if using authUrl with some authParams and authMethod = POST it sends the post body JSON-encoded, not form-encoded. (It's a breaking change, so we'll have to consider whether to put off the fix for the next major version).

Incorrect test: https://github.com/ably/ably-ios/blob/4a22afe3da2af00d687748330d2ac45c23aaf5f1/Spec/Auth.swift#L1387

┆Issue is synchronized with this Jira Bug by Unito
@SimonWoolf SimonWoolf added the bug Something isn't working. It's clear that this does need to be fixed. label Feb 12, 2018
@funkyboy funkyboy self-assigned this Feb 15, 2018
@ricardopereira ricardopereira mentioned this issue Sep 27, 2019
Merged
@maratal maratal closed this as completed Sep 17, 2021
@ably-sync-bot
Copy link

➤ Marat Alekperov commented:

Was fixed here #899 ( https://github.com/ably/ably-cocoa/pull/899|smart-link ) and here #983 ( https://github.com/ably/ably-cocoa/pull/983|smart-link )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@funkyboy @SimonWoolf @maratal @ably-sync-bot