Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PushChannel.subscribe should not call the callback in the internal queue #862

Closed
ricardopereira opened this issue Jun 14, 2019 · 0 comments · Fixed by #885
Closed

PushChannel.subscribe should not call the callback in the internal queue #862

ricardopereira opened this issue Jun 14, 2019 · 0 comments · Fixed by #885
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ricardopereira
Copy link
Contributor 

Main Thread Checker: UI API called on a background thread: -[UITextView text]
PID: 22895, TID: 4707586, Thread name: (none), Queue name: io.ably.main, QoS: 0
Backtrace:
4   AblyPushFCM                         0x000000010024f480 $s11AblyPushFCM14ViewControllerC27subscribeClientButtonTappedyyypFySo12ARTErrorInfoCSgcfU_ + 1372
5   AblyPushFCM                         0x000000010024eb10 $sSo12ARTErrorInfoCSgIegg_ACIeyBy_TR + 80
6   Ably                                0x0000000100850fe8 __34-[ARTPushChannel subscribeClient:]_block_invoke + 596
7   Ably                                0x000000010089fc6c __55-[ARTRest executeRequest:completion:fallbacks:retries:]_block_invoke + 4164
8   Ably                                0x000000010082af04 __37-[ARTHttp executeRequest:completion:]_block_invoke + 1096
9   Ably                                0x00000001008bf064 __43-[ARTURLSessionServerTrust get:completion:]_block_invoke_2 + 60
10  libdispatch.dylib                   0x0000000100d1f6f0 _dispatch_call_block_and_release + 24
11  libdispatch.dylib                   0x0000000100d20c74 _dispatch_client_callout + 16
12  libdispatch.dylib                   0x0000000100d28bf4 _dispatch_lane_serial_drain + 712
13  libdispatch.dylib                   0x0000000100d298b4 _dispatch_lane_invoke + 456
14  libdispatch.dylib                   0x0000000100d3377c _dispatch_workloop_worker_thread + 1148
15  libsystem_pthread.dylib             0x00000001f2d2d114 _pthread_wqthread + 304
16  libsystem_pthread.dylib             0x00000001f2d2fcd4 start_wqthread + 4
2019-06-14 19:27:42.570875+0100 AblyPushFCM[22895:4707586] [reports] Main Thread Checker: UI API called on a background thread: -[UITextView text]
PID: 22895, TID: 4707586, Thread name: (none), Queue name: io.ably.main, QoS: 0
Backtrace:
4   AblyPushFCM                         0x000000010024f480 $s11AblyPushFCM14ViewControllerC27subscribeClientButtonTappedyyypFySo12ARTErrorInfoCSgcfU_ + 1372
5   AblyPushFCM                         0x000000010024eb10 $sSo12ARTErrorInfoCSgIegg_ACIeyBy_TR + 80
6   Ably                                0x0000000100850fe8 __34-[ARTPushChannel subscribeClient:]_block_invoke + 596
7   Ably                                0x000000010089fc6c __55-[ARTRest executeRequest:completion:fallbacks:retries:]_block_invoke + 4164
8   Ably                                0x000000010082af04 __37-[ARTHttp executeRequest:completion:]_block_invoke + 1096
9   Ably                                0x00000001008bf064 __43-[ARTURLSessionServerTrust get:completion:]_block_invoke_2 + 60
10  libdispatch.dylib                   0x0000000100d1f6f0 _dispatch_call_block_and_release + 24
11  libdispatch.dylib                   0x0000000100d20c74 _dispatch_client_callout + 16
12  libdispatch.dylib                   0x0000000100d28bf4 _dispatch_lane_serial_drain + 712
13  libdispatch.dylib                   0x0000000100d298b4 _dispatch_lane_invoke + 456
14  libdispatch.dylib                   0x0000000100d3377c _dispatch_workloop_worker_thread + 1148
15  libsystem_pthread.dylib             0x00000001f2d2d114 _pthread_wqthread + 304
16  libsystem_pthread.dylib             0x00000001f2d2fcd4 start_wqthread + 4
@ricardopereira ricardopereira added bug Something isn't working. It's clear that this does need to be fixed. push labels Jun 14, 2019
@ricardopereira ricardopereira changed the title PushChannel.subscribe should not call the user callback in the internal queue PushChannel.subscribe should not call the callback in the internal queue Jul 13, 2019
@ricardopereira ricardopereira mentioned this issue Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Push Channel callbacks ably/ably-cocoa
1 participant
@ricardopereira