Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestClientStats tests are failing inconsistently. #142

Closed
tcard opened this issue Jan 20, 2016 · 4 comments
Closed

RestClientStats tests are failing inconsistently. #142

tcard opened this issue Jan 20, 2016 · 4 comments

Comments

@tcard
Copy link
Contributor

tcard commented Jan 20, 2016

From time to time, a RestClientStats test fails with an off-by-one error.

[16:18:08]: ▸ ablySpec.RestClientStats
[16:18:08]: ▸ RestClient__stats__result__should_match_hour_level_inbound_and_outbound_fixture_data__forwards__UserstravisbuildablyablyiosablySpecRestClientstatsswift_160, failed - expected to equal <1>, got <2>
[16:18:08]: ▸ /Users/travis/build/ably/ably-ios/ablySpec/RestClient.stats.swift:181
[16:18:08]: ▸ ```
[16:18:08]: ▸ 
[16:18:08]: ▸                         expect(result.items.count).to(equal(1))
[16:18:08]: ▸                         expect(totalInbound).to(equal(50 + 60 + 70))
[16:18:08]: ▸   ```
[16:18:08]: ▸      Executed 190 tests, with 1 failure (0 unexpected) in 508.631 (509.033) seconds
[16:18:08]: ▸ 
@tcard
Copy link
Contributor Author

tcard commented Jan 20, 2016

Another failure that has nothing to do with the new code (#144):

[17:08:50]: ▸ ablySpec.RestChannel
[17:08:50]: ▸ presence__get__should_return_presence_fixture_data_UserstravisbuildablyablyiosablySpecRestChannelswift_206, failed - expected to eventually equal <6>, got <0>
[17:08:50]: ▸ /Users/travis/build/ably/ably-ios/ablySpec/RestChannel.swift:216
[17:08:50]: ▸ ```
[17:08:50]: ▸ 
[17:08:50]: ▸                     expect(presenceMessages.count).toEventually(equal(presenceFixtures.count), timeout: testTimeout)
[17:08:50]: ▸                     for message in presenceMessages {
[17:08:50]: ▸   ```
[17:08:50]: ▸      Executed 185 tests, with 1 failure (0 unexpected) in 551.620 (551.911) seconds

This looks like a timeout in Presence.get. testTimeout is 10 s, so it's taking longer than that, which is not good. Maybe it's a problem of Travis itself? The alternative is that something is wrong in realtime.

@tcard
Copy link
Contributor Author

tcard commented Feb 2, 2016

@ricardopereira Why did you close this? Last time I checked (when trying out #173) it was still happening.

@ricardopereira
Copy link
Contributor

I thought it was fixed.

@tcard
Copy link
Contributor Author

tcard commented Nov 3, 2017

#278 fixes this.

@tcard tcard closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants