Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RealtimeChannel: attach is inconsistent with the API #189

Closed
ricardopereira opened this issue Feb 3, 2016 · 2 comments
Closed

RealtimeChannel: attach is inconsistent with the API #189

ricardopereira opened this issue Feb 3, 2016 · 2 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ricardopereira
Copy link
Contributor

attach is returning an ARTErrorInfo.

Callback not implemented and the language permits:

(RTL4d) If the language permits, a callback can be provided that is called when the channel is attached successfully or the attach fails and the the ErrorInfo error is passed as an argument to the callback.
@ricardopereira ricardopereira added bug Something isn't working. It's clear that this does need to be fixed. realtime labels Feb 3, 2016
@mattheworiordan
Copy link
Member

Thanks, this is quite useful functionality so we should aim to implement this.

tcard added a commit that referenced this issue Feb 15, 2016
@tcard
Refactor channels to adjust to API spec.
97f0b16 
Using EventEmitter to emit state changes and messages.

Fixes #134, #183, #121, #189.
@tcard
Copy link
Contributor

tcard commented Feb 15, 2016

Fixed by #204.

@tcard tcard closed this as completed Feb 15, 2016
maratal pushed a commit that referenced this issue Jul 19, 2023
@trenouf @SimonWoolf
RTL4g: fixed reference to duplicate RTL4h that was renamed RTL4i (#189)
a081b32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattheworiordan @tcard @ricardopereira