Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught Exception: '-[__NSCFURLSessionConnection performDefaultHandlingForAuthenticationChallenge:]: unrecognized selector #674

Closed
mattheworiordan opened this issue Jan 30, 2018 · 6 comments
Closed

Uncaught Exception: '-[__NSCFURLSessionConnection performDefaultHandlingForAuthenticationChallenge:]: unrecognized selector #674

mattheworiordan opened this issue Jan 30, 2018 · 6 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@mattheworiordan
Copy link
Member

mattheworiordan commented Jan 30, 2018 •
edited
Loading

Reported crash on device:

SDK version: 1.0.5

OS Version: 11.2.2 (15C202)

Device: iPhone X

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFURLSessionConnection performDefaultHandlingForAuthenticationChallenge:]: unrecognized selector sent to instance 0x7ff06d958410'

Crash report is at https://app.intercom.io/a/apps/ua39m1ld/respond/inbox/conversation/14348764648

Possibly related: https://stackoverflow.com/questions/27604052/nsurlsessiontask-authentication-challenge-completionhandler-and-nsurlauthenticat

Question: Is this crash happening during reporting of an issue i.e. sentry error reporting, and thus it's crashing the apps as opposed to handling the error and moving the connection to the failed state with a suitable error?
@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 30, 2018
@funkyboy
Copy link
Contributor

UPDATE: waiting for customer to confirm that this happens also on 1.0.10

@ricardopereira
Copy link
Contributor

This has been fixed in the push branch, see: https://github.com/ably/ably-ios/blob/b9c0951b982399003935f3c9d89dc87343776894/Source/ARTURLSessionServerTrust.m#L45

The commit with that change is 28134c2

@ricardopereira
Copy link
Contributor

@funkyboy Should we fix it on master as well and do a patch release?

@funkyboy
Copy link
Contributor

@ricardopereira yes please. Make a PR just with that change, so we can make a patch release.

@ricardopereira ricardopereira mentioned this issue Jan 31, 2018
Merged
@ricardopereira
Copy link
Contributor

@funkyboy Done ^

@funkyboy
Copy link
Contributor

Fixed in #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattheworiordan @funkyboy @ricardopereira