Unable to submit to AppStore #803
Comments
|
@hliu2000 that's an odd one, we've not had that reported before. We're assigning to two of our iOS engineers to comment. |
|
@funkyboy Any idea? SocketRocket has the key https://github.com/facebook/SocketRocket/blob/28035e1a98a427853e4038ff1b70479fa8374cfa/SocketRocket/Resources/Info.plist#L21-L22 Maybe a Carthage issue. |
|
It's a known issue 😕 facebookincubator/SocketRocket#591 |
|
See #701 |
|
@funkyboy Thanks! That's it 💪 So the workaround is changing the |
|
Last time we had this issue it worked |
|
Ok, thanks. @hliu2000 could you please try setting the |
|
Hi Ricardo,
I could try that, but it won't work for our CI system since the
Carthage/Build/iOS
folder is generated. Also I don't want to hack our CI system for this.
I know this is a work around, but will this problem been solved in next
Ably version? Other developer using Ably will have the same problem anyway.
It will be great if you can provide a time estimate about when this can be
solved.
…On Wed, Sep 26, 2018 at 4:56 PM Ricardo Pereira ***@***.***> wrote:
Ok, thanks.
@hliu2000 <https://github.com/hliu2000> could you please try setting the
CFBundleVersion to 1.0.0 from
Carthage/Build/iOS/SocketRocket.framework/Info.plist and try submit the
app again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#803 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AplzTPdCdE4VMAG3pVzmDmF6GyJdUw9aks5ue6OegaJpZM4W6uG_>
.
|
|
@hliu2000 I know we've been talking about replacing SocketRocket completely as it's no longer actively maintained. We'll back to you with a plan soon. |
|
That's great, thanks a lot.
…On Wed, Sep 26, 2018 at 6:42 PM mattheworiordan ***@***.***> wrote:
@hliu2000 <https://github.com/hliu2000> I know we've been talking about
replacing SocketRocket completely as it's no longer actively maintained.
We'll back to you with a plan soon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#803 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AplzTJ1N6jFJMYFSU6y9sMgkwwDTCMChks5ue7xugaJpZM4W6uG_>
.
|
|
Hey @hliu2000. We have chatted internally, and believe we'll go with a short term fix so that you can get this deployed now, and then look at a longer term solution for SocketRocket. Short term fix will require us to fork SocketRocket, and also address #804. We'll do that ASAP. Longer term fix is to replace SocketRocket completely, see #805. We'll give you an update shortly. |
mattheworiordan
added
the
bug
|
Thanks, really appreciated.
…On Thu, Sep 27, 2018 at 7:34 PM mattheworiordan ***@***.***> wrote:
Hey @hliu2000 <https://github.com/hliu2000>. We have chatted internally,
and believe we'll go with a short term fix so that you can get this
deployed now, and then look at a longer term solution for SocketRocket.
Short term fix will require us to fork SocketRocket, and also address #804
<#804>. We'll do that ASAP.
Longer term fix is to replace SocketRocket completely, see #805
<#805>.
We'll give you an update shortly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#803 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AplzTE3o-U5buU38GQo0g5VLS6Gg6ADnks5ufRoagaJpZM4W6uG_>
.
|
|
@hliu2000 Patch has been released and tested https://github.com/ably/ably-ios/releases/tag/1.1.1. |
|
Great, thanks. |
|
Closing this. Feel free to reopen as you see fit. |
Which version of the Ably SDK are you using?
1.1.0
On which platform does the issue happen?
iOS
Are you using Carthage?
Yes, 0.28.0
Are you using Cocoapods?
No
Which version of Xcode are you using?
Xcode 9.2
What did you do?
We are trying to use Ably in our iOS app, everything is fine until when we submit it to AppStore, got the error from iTunes Connect:
This issue is caused by the SocketRocket dependency used by Ably.
This is blocking us from submitting our App to AppStore, please resolve this as soon as possible.
The text was updated successfully, but these errors were encountered: