RTN7a #125
Merged
RTN7a #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattheworiordan What is the best approach to test |
|
Needs #128 I was not receiving the ACK related with the Presence call. |
|
Few comments, but not sure they are relevant to this PR necessarily and could be separate issues. |
|
I think this PR needs to deal with |
ricardopereira
force-pushed
the
RTN7a
branch
2 times, most recently
from
65cef35 to
fff7b7b
Compare
- Added `art_nullable` keyword
…the published message
ricardopereira
force-pushed
the
RTN7a
branch
2 times, most recently
from
cdf32c8 to
14f1a8c
Compare
- RTN6, RTN7, RTN8
- ARTMessage, ARTPresenceMessage
- Was ignoring the ProtocolMessage.error property
- Was ignoring the Channel failed state
- Was assigning the last `msgSerial` received and should have the first `msgSerial` from `pendingMessages`
- Process all the available pending messages
- Should reset both values when a new connection (not resumed or recoverd) is established
|
@mattheworiordan @tcard Ready to be reviewed. |
|
Nice, LGTM 👍 |
|
LGTM |
tcard
added a commit
that referenced
this pull request
Jan 20, 2016
maratal
pushed a commit
that referenced
this pull request
Jul 19, 2023
Document Release Process: Specification Version Bumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.