Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable RestClientStats tests. #144

Merged
merged 2 commits into from
Jan 20, 2016
Merged

Temporarily disable RestClientStats tests. #144

merged 2 commits into from
Jan 20, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Jan 20, 2016

Until #142 is addressed, to avoid blocking the test suite.

Until #142 is addressed, to avoid blocking the test suite.
@tcard
Copy link
Contributor Author

tcard commented Jan 20, 2016

One test fails due to the second comment at #142 , the other due to #143 . Should be considered passing.

@ricardopereira
Copy link
Contributor

Ok, LGTM

tcard added a commit that referenced this pull request Jan 20, 2016
Temporarily disable RestClientStats tests.
@tcard tcard merged commit 8e3c4c9 into master Jan 20, 2016
@ricardopereira
Copy link
Contributor

Why didn't you amend the commit?

@ricardopereira
Copy link
Contributor

Sorry, should asked it before saying LGTM.

@tcard tcard deleted the disable-stats branch January 20, 2016 19:03
@tcard
Copy link
Contributor Author

tcard commented Jan 20, 2016

@ricardopereira Yeah, could've done that... Github gives some friction abut that though.

@mattheworiordan
Copy link
Member

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants