RTN14b #167
Merged
RTN14b #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is not passing. The lib only gives the |
ricardopereira
force-pushed
the
RTN14b
branch
from
0c323c1 to
c1ef9be
Compare
|
I still don't understand why one of those tests passes and the other fails when both seem to not have any mechanism to renew the token. The tests look wrong to me |
ricardopereira
force-pushed
the
RTN14b
branch
2 times, most recently
from
5a5da32 to
7a3eff3
Compare
| // New token | ||
| expect(client.auth().tokenDetails!.token).toNot(equal(options.token)) | ||
| done() | ||
| case .Failed: |
There was a problem hiding this comment.
Mind adding the Disconnected state in here too as it should not reach Disconnected, Suspended or Failed states?
|
Few small comments, please address those and from my side I am happy for you to merge then |
ricardopereira
force-pushed
the
RTN14b
branch
from
7a3eff3 to
afa4d6d
Compare
|
All comments addressed. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test doesn't pass.