Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN18a #168

Merged
merged 1 commit into from
Jan 28, 2016
Merged

RTN18a #168

merged 1 commit into from
Jan 28, 2016

Conversation

ricardopereira
Copy link
Contributor

✅ Passing

@mattheworiordan
Copy link
Member

LGTM

@ricardopereira
Copy link
Contributor Author

It is important to merge #169 first, rebase with master and check if it is ok.

@ricardopereira
Copy link
Contributor Author

@tcard I run the complete test suite and it's failing with:

RestClient__initializer__should_accept_a_token_UsersricardopereiraRepositoriesWhitesmithablyiosablySpecRestClientswift_48, failed - Got error 'Error Domain=io.ably.cocoa Code=40100 "" UserInfo={ARTErrorStatusCode=401, NSLocalizedDescription=, NSLocalizedFailureReason=invalid credentials}'
/Users/ricardopereira/Repositories/Whitesmith/ably-ios/ablySpec/TestUtilities.swift:215

RestClient__initializer__should_accept_a_token_UsersricardopereiraRepositoriesWhitesmithablyiosablySpecRestClientswift_48, failed - expected to eventually be nil, got <Error Domain=io.ably.cocoa Code=40100 "" UserInfo={ARTErrorStatusCode=401, NSLocalizedDescription=, NSLocalizedFailureReason=invalid credentials}>
/Users/ricardopereira/Repositories/Whitesmith/ably-ios/ablySpec/RestClient.swift:51

The tests were passing when you implemented the initWithToken? Or are they missing the pending?

@tcard
Copy link
Contributor

tcard commented Jan 27, 2016

The tests were passing when you implemented the initWithToken?

On my machine, yes. I run them again against master and it's still happily passing. Weird...

ricardopereira added a commit that referenced this pull request Jan 28, 2016
@ricardopereira
Merge pull request #168 from ably/RTN18a
e172cd9 
RTN18a
@ricardopereira ricardopereira merged commit e172cd9 into master Jan 28, 2016
@ricardopereira ricardopereira deleted the RTN18a branch January 28, 2016 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @mattheworiordan @tcard