Test suite websocket #169
Merged
Test suite websocket #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ARTProtocolMessage
…e, simulateIncomingError and simulateLostConnection
- Tests should use each event (onConnected, onError, onDisconnected, onSuspended…) to change the connection state because using the `transition` method will ignore some logic.
|
@tcard What do you think? |
| @@ -446,7 +446,7 @@ -(void) cancelPingTimer { | |||
| self.pingTimeout = nil; | |||
| } | |||
|
|
|||
| - (void)onHeartbeat:(ARTProtocolMessage *)message { | |||
| - (void)onHeartbeat { | |||
There was a problem hiding this comment.
Why did you remove the ProtocolMessage?
There was a problem hiding this comment.
Because the method was not using it.
|
Looks fine, few comments re: naming |
ricardopereira
force-pushed
the
test-suite-websocket
branch
from
ba7dbc3 to
5a6072c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
client.transitionto simulate incomings of errors & connection state change and it is wrong because some of the logic is missed.To change the connection states:
client.onConnected(message: ARTProtocolMessage)client.onDisconnected()client.onSuspended()client.onError(AblyTests.simulateError())With this PR we have:
simulateIncomingNormalClosesimulateIncomingAbruptlyClosesimulateIncomingErrorsimulateLostConnection