RTL1 #180
Merged
RTL1 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopereira
force-pushed
the
RTL1
branch
2 times, most recently
from
e688705 to
9b09ba3
Compare
|
|
||
| /// List of members. | ||
| /// The key is the clientId and the value is the latest relevant ARTPresenceMessage for that clientId. | ||
| @property (readonly, atomic, getter=getMembers) __GENERIC(NSDictionary, NSString *, ARTPresenceMessage *) *members; |
There was a problem hiding this comment.
There is no public members property in the API, only get, see http://docs.ably.io/client-lib-development-guide/features/#RSP3
There was a problem hiding this comment.
But this is related with the PresenceMap, not with the Presence himself. Maybe it isn't consistent with other clients.
(RTP2) A PresenceMap should be used to maintain a list of members present on a channel.
There was a problem hiding this comment.
The presence API is pretty broken anyway already. I see that you're only adding generics, which I think is OK. I'll get the API right.
There was a problem hiding this comment.
Ok, thanks @tcard, @ricardopereira ignore my comments tehne
|
LGTM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.