RTL4b #187
Merged
RTL4b #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| client.close() | ||
| expect(client.connection().state).to(equal(ARTRealtimeConnectionState.Closing)) | ||
|
|
||
| expect(channel.attach()).toNot(beNil()) |
There was a problem hiding this comment.
This is not clear that this is an error, this applies to all cases below.
There was a problem hiding this comment.
Can I correct this after the API changes?
There was a problem hiding this comment.
Ok, please add a TODO or an issue though so we don't forget
|
Looks good other than the one comment |
|
LGTM |
|
Rebased with no changes. |
|
This can be merged, right? |
|
Sure, merge away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.