Minor changes to adjust to API spec. #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,4 +34,8 @@ - (NSString *)description { | |||
| return description; | |||
| } | |||
|
|
|||
| - (NSString *)memberKey { | |||
| return [NSString stringWithFormat:@"%@:%@", self.connectionId, self.clientId]; | |||
There was a problem hiding this comment.
Should it return an empty string if the connectionId or clientId are nil?
It will return (null):(null) if both properties are nil.
There was a problem hiding this comment.
In PresenceMessage both connectionId and clientId are defined as non-nullable, so that's something we don't have to worry about.
There was a problem hiding this comment.
Yes, sorry. I thought both were nullable.
|
LGTM |
1 similar comment
|
LGTM |
tcard
added a commit
that referenced
this pull request
Feb 9, 2016
Minor changes to adjust to API spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think those aren't relevant enough to grant each its own pull request.