RTN15e #251
Merged
RTN15e #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be rebased with #228 fixes. |
| channel.attach() | ||
| expect(channel.state).toEventually(equal(ARTRealtimeChannelState.Attached), timeout: testTimeout) | ||
|
|
||
| client.onDisconnected() |
There was a problem hiding this comment.
Why don't you add a once(.Connecting) step that explicitly resets the key to another value. That way you can be sure the iOS code is actually updating the Connection#key?
There was a problem hiding this comment.
Done cc419e7.
ricardopereira
force-pushed
the
RTN15e
branch
from
6a9aaad to
cc419e7
Compare
|
Rebased with master with changes: cc419e7. |
|
LGTM |
1 similar comment
|
LGTM |
ricardopereira
force-pushed
the
RTN15e
branch
from
cc419e7 to
958cdd6
Compare
ricardopereira
added a commit
that referenced
this pull request
Feb 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.