Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 7.2 (use xcodebuild) #265

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Xcode 7.2 (use xcodebuild) #265

merged 1 commit into from
Mar 1, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@tcard
Copy link
Contributor

tcard commented Mar 1, 2016

Well, this one doesn't seem to have stalled. LGTM, let's see if this proves more stable, although I'm a bit skeptical since it was stalling also before we were using scan...

tcard added a commit that referenced this pull request Mar 1, 2016
@tcard
Merge pull request #265 from ably/travis-enhance
a7ef827 
Xcode 7.2 (use xcodebuild)
@tcard tcard merged commit a7ef827 into master Mar 1, 2016
@ricardopereira
Copy link
Contributor Author 

Failing tests:
    -[ARTRestInitTest testInitWithKey]
    -[RealtimeClientChannel Channel__should_process_all_incoming_messages_and_presence_messages_as_soon_as_a_Channel_becomes_attached()]
    -[RestClient RestClient__logging__should_output_to_the_system_log_and_the_log_level_should_be_Warn()]
    -[RestClientChannels RestClient__channels__releaseChannel__should_release_a_channel()]

@tcard Can we merge #253? It fixes the log error.

I will check the testInitWithKey and Channel__should_process_all_incoming_messages_and_presence_messages_as_soon_as_a_Channel_becomes_attached.

@tcard
Copy link
Contributor

tcard commented Mar 1, 2016

@ricardopereira @253 is missing @mattheworiordan 's LGTM.

@ricardopereira ricardopereira deleted the travis-enhance branch March 1, 2016 09:08
@mattheworiordan
Copy link
Member

Sorry for the delay, but LGTM. Will review #253 now

This was referenced Mar 1, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @tcard @mattheworiordan