Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth.canRequestToken and Auth.validate revision #29

Merged
merged 2 commits into from
Oct 20, 2015
Merged

Auth.canRequestToken and Auth.validate revision #29

merged 2 commits into from
Oct 20, 2015

Conversation

ricardopereira
Copy link
Contributor

I removed canRequestToken. It isn't necessary because the constructor does the validation.

Fixed isBasicAuth with:

It defaults to basic auth if the keyValue is provided, and there is no clientId specified. In this case, however, useTokenAuth forces token auth to be used.

@ricardopereira
Copy link
Contributor Author

First merge!

@paddybyers
Copy link
Member

LGTM

@paddybyers paddybyers merged commit 3283967 into ably:master Oct 20, 2015
@ricardopereira ricardopereira deleted the token-request-revision branch October 20, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @paddybyers