Client manage token requests #30
Conversation
- Auth.authorise was missing the possibility of receiving just an access token. - Auth.options.clientId can be nil. - Sign TokenRequest with clientId=* when the user is anonymous. - Rest.calculateAuthorization was missing the Auth.authorise for token reusability.
|
Second merge! |
| @@ -143,7 +145,7 @@ - (ARTAuthTokenRequest *)sign:(NSString *)key { | |||
| NSString *keyName = keyComponents[0]; | |||
| NSString *keySecret = keyComponents[1]; | |||
| NSString *nonce = generateNonce(); | |||
| NSString *clientId = self.clientId ? self.clientId : @""; | |||
| NSString *clientId = self.clientId ? self.clientId : @"*"; | |||
There was a problem hiding this comment.
@paddybyers Correct?
There was a problem hiding this comment.
@paddybyers Correct?
No, I don't think so. A TokenRequest only contains the wildcard clientId if explicitly requested by the caller.
If the caller does not specify a clientId, and the Ably library was not initialised with a clientId, then the token request does not contain any clientId. For the purposes of canonicalisation, if there is no clientId then an empty string is used in place of the clientId to construct the canonical text.
There was a problem hiding this comment.
Done. The authentication is working.
The problem: - The Auth.authorise was requesting a new token with authMethod=Token. Now, the request has 3 possibilities: - AuthorizationOn - AuthorizationOff - AuthorizationUseBasic
|
@paddybyers Please merge when it's possible. Sorry for the long change. It was really necessary because the Both authentication methods are stable now. |
Client manage token requests
|
Thanks |
RAS7a1andRAS7a2are failing. Will check that on the next PR.