Realtime transport auth fixed (RTC1) #31
Conversation
| return; | ||
| } | ||
|
|
||
| NSURLQueryItem *accessTokenParam = [NSURLQueryItem queryItemWithName:@"access_token" value:decodeBase64(tokenDetails.token)]; |
There was a problem hiding this comment.
@paddybyers Correct? I'm decoding the access token (decodeBase64).
There was a problem hiding this comment.
There shouldn't be any need to decode the token
|
Merge when it's possible. Thank you, |
|
Can you check that comment above about the token? You should treat the token string as opaque. |
|
@paddybyers But the received token is encoded and then the it's not possible to establish connection to the realtime server. |
|
@ricardopereira realtime provides it as a base64-encoded string, and expects back the same base64-encoded string. If it's not working unless you have a decode in there, I'd hazard a guess that there's code elsewhere that's mistakenly encoding it before sending it. (The client lib can't do anything with it decoded anyway -- it won't be valid ascii when decoded, just binary nonsense) |
|
@SimonWoolf Ok, I will investigate. Thanks. |
|
@paddybyers @SimonWoolf Fixed. Encoder was misplaced on ARTAuth. |
Realtime transport auth fixed (RTC1)
|
Thanks |
Addresses issue whereby a client authenticated with a wildcard clientId value (indicating any clientId can be assumed), is not reflected to anyone observing the client i.e. Auth#clientId is null, yet Auth#clientId is also null when a client is anonymous. Addresses realtime issue #349 and wiki issue #31 See ably/ably-ruby#66 for this issue discovered in ably-ruby
RTC1is passing.Next on new PR:
ARTErrorneed to be aNSError.