RTP16c #318
Merged
RTP16c #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context("Connection state conditions") { | ||
|
|
||
| // RTP16c | ||
| pending("should result in an error if the connection state is INITIALIZED") { |
There was a problem hiding this comment.
I'm probably missing something, but where in this test is the connection INITIALIZED? Won't it be CONNECTING right away?
Also, I'm not really sure this applies to INITIALIZED since it's not an state change. @mattheworiordan could you confirm this?
There was a problem hiding this comment.
Yes, you right. The connection is in the CONNECTING state. I verified the ruby test (keep in mind that I'm not comfortable with ruby) and it seems to check the INITIALIZED state: https://github.com/ably/ably-ruby/blob/6e8e1ea7949026f19fa4c1405ccb5d8b96c3aeb9/spec/acceptance/realtime/presence_spec.rb#L58-L64
There was a problem hiding this comment.
Done aef47db.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.