RTP10b #337
Merged
RTP10b #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
PTAL. The test wasn't actually working because we were simulating an ERROR protocol message that had nothing to do with the LEAVE operation, so it didn't affect it at all; the ACK arrived just fine. What we need is to replace the arriving ACK with a NACK to trigger the error in the callback. |
|
Cool, thanks. |
tcard
force-pushed
the
rtp10b
branch
2 times, most recently
from
689eac1 to
e6818a2
Compare
| @@ -868,7 +868,7 @@ class RealtimeClientPresence: QuickSpec { | |||
| defer { client.close() } | |||
| let channel = client.channels.get("test") | |||
|
|
|||
| channel.attach() | |||
| channel.attach() | |||
There was a problem hiding this comment.
Done 3200787.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.