RSA8f2 #349
Merged
RSA8f2 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // RSA8f2 | ||
| it("ensure that the message is rejected") { | ||
| let token = getTestToken() | ||
| let options = ARTClientOptions(token: token) |
There was a problem hiding this comment.
Has this token got a null value clientId?
There was a problem hiding this comment.
Done 70ab463.
ricardopereira
force-pushed
the
rsa8f2
branch
2 times, most recently
from
70ab463 to
099c2fb
Compare
|
LGTM |
ricardopereira
added a commit
that referenced
this pull request
Dec 21, 2017
ricardopereira
added a commit
that referenced
this pull request
Dec 22, 2017
* Fix RTP2a * Fix RTP2e * Fix RTL1 * Fix Realtime Host Fallback tests * Fix RTP15e: check errorReason * Add extra protections when ARTPaginatedResult is being used * Fix RTC8b1 * Ignore didAuthorize when connection is closing * Fix RTN14a * Fix RTP19: presenceMap use memberKey as dict key * Fix presence leave test where an error should exist when clientId is missing * Ignore message when it's disconnected * Do not request a Sync when an ATTACHED is received (see #349) * Fix RTP2f * Fix RTP5a * Fix RTP8b * Fix RTP11b * Better treatment when connection is refused * Add ARTAuthorizationCancelled * Ignore message when socket is closed * Log EventEmitter events * Better timings * Fix RTN13c * Enhance RTL6c3 for better reliance * Fix RTC3: close connection * Fix: set attach timer after the connection is active * Should not rely on publish callback because the message is queued * Idle timer should stop when connection is closing * OSReachability should check if the callback is assigned * Better debug info - Add channels name * Fix RTN7c: `simulateIncomingNormalClose` is an unexpected closure so it will move to disconnected to recover
maratal
pushed a commit
that referenced
this pull request
Jul 19, 2023
Addresses issue whereby a client authenticated with a wildcard clientId value (indicating any clientId can be assumed), is not reflected to anyone observing the client i.e. Auth#clientId is null, yet Auth#clientId is also null when a client is anonymous. Addresses realtime issue #349 and wiki issue #31 See ably/ably-ruby#66 for this issue discovered in ably-ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.