RSC15d #383
Merged
RSC15d #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopereira
force-pushed
the
rsc15d
branch
2 times, most recently
from
119c0c7 to
7fae0fd
Compare
| let options = ARTClientOptions(key: "xxxx:xxxx") | ||
| let client = ARTRest(options: options) | ||
| client.httpExecutor = testHTTPExecutor | ||
| testHTTPExecutor.http = MockHTTP(network: .HostBadRequest) |
There was a problem hiding this comment.
What is the definition of a bad request?
There was a problem hiding this comment.
Ignore me, I see below... that is fine. Perhaps update the name to HostBadRequest400 to make it clearer for dummies like me :)
|
PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.