RTN16d #394
Merged
RTN16d #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| let firstConnectionDetails = transport.protocolMessagesReceived.filter{ $0.action == .Connected }.first!.connectionDetails | ||
| expect(firstConnectionDetails!.connectionKey).toNot(beNil()) | ||
| expect(clientRecover.connection.id).to(equal(expectedConnectionId)) | ||
| expect(clientRecover.connection.key).to(equal(firstConnectionDetails!.connectionKey)) |
There was a problem hiding this comment.
I am not sure this is right, the connection key can change when the connection is recovered, the only guarantee is that the connection ID remains the same
There was a problem hiding this comment.
This is right. It's checking that the connection key is the new one received in the CONNECTED message from the server (firstConnectionDetails), not that it's keeping the old connection key. (Maybe the name firstConnectionDetails is a bit misleading?)
There was a problem hiding this comment.
Yes, it should be something like recoveredConnectionDetails :/
|
Please review as I am not sure this is correct @tcard @ricardopereira |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.