RTL6c #406
RTL6c #406
Conversation
|
LGTM but will be revisited following @tcard's updates to the spe |
|
PTAL |
|
(By the way, that's up to date with ably/docs#112.) |
It wasn't really testing the right thing. Should test when connection is _already_ CONNECTED.
According to ably/docs#112.
| } | ||
|
|
||
| // RTL6c2 | ||
| context("the message should be queued and delivered as soon as the connection state returns to CONNECTED if the connection is") { |
There was a problem hiding this comment.
The tests in this context test the message should be queued, but don't test and delivered as soon as the connection state returns to CONNECTED. Should we?
There was a problem hiding this comment.
It is tested. All of them are calling a local publish function (line 1150) which publishes and waits for the callback. Or do you want to also subscribe to the channel and check if it's received? I don't think that's necessary, as other tests already prove that the publish callback is called upon successful delivery.
There was a problem hiding this comment.
Yes, you are right, leave as is
|
One comment but otherwise great 👍 |
No description provided.