Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN14d #422

Merged
merged 7 commits into from
Apr 29, 2016
Merged

RTN14d #422

merged 7 commits into from
Apr 29, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@mattheworiordan
Copy link
Member

👍

@tcard
Copy link
Contributor

tcard commented Apr 28, 2016

PTAL

@ricardopereira
Copy link
Contributor Author

Looks good but one test is failing: Channel__attach__should_transition_the_channel_state_to_FAILED_if_ATTACHED_ProtocolMessage_is_not_received

ricardopereira and others added 7 commits April 29, 2016 13:20
@ricardopereira @tcard
Add ARTConnectionStateChange description
47e928d 
 - added `ARTRealtimeConnectionStateString` to return the string from
enum
@ricardopereira @tcard
RTN14d
f658d06
@ricardopereira @tcard
RTN14d: pending
8dc7b9c
@tcard
Fix RTN14d.
a9ee259
@tcard
Deduplicate realtime state enum stringer.
827b24d 
There was already a method doing this.
@tcard
Fixup.
1b372bb
@tcard
Fixup.
498698e
@tcard tcard merged commit 9bbb1f3 into master Apr 29, 2016
@tcard tcard deleted the rtn14d branch April 29, 2016 11:56
tcard pushed a commit that referenced this pull request May 16, 2016
@ricardopereira @tcard
RTN14d (#422)
a575113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @mattheworiordan @tcard